Skip to content

tee: allow multiple -a flags#10293

Merged
ChrisDryden merged 1 commit intouutils:mainfrom
sylvestre:tee-a
Jan 17, 2026
Merged

tee: allow multiple -a flags#10293
ChrisDryden merged 1 commit intouutils:mainfrom
sylvestre:tee-a

Conversation

@sylvestre
Copy link
Contributor

@sylvestre sylvestre commented Jan 17, 2026

@sylvestre
tee: allow multiple -a flags
14c517e 
Fixes issue where tee rejected multiple append flags with error
"the argument '--append' cannot be used multiple times".
GNU tee accepts multiple -a flags, so this adds compatibility.
ChrisDryden
ChrisDryden approved these changes Jan 17, 2026
View reviewed changes
Copy link
Collaborator

@ChrisDryden ChrisDryden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a good test to upstream to the gnu test suite

@ChrisDryden
Copy link
Collaborator

ChrisDryden commented Jan 17, 2026

I'm trying to brainstorm how to systemically test to see the variance with multiple flags for all of the options, given how simple the fix is, it would be good to make a script to go through every option and see what happens when multiple of a flag is provided or validate this is a niche use case.

@sylvestre
Copy link
Contributor Author

sylvestre commented Jan 17, 2026

probably a variance of fuzz/fuzz_targets/fuzz_non_utf8_paths.rs

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 17, 2026

Merging this PR will degrade performance by 27.39%

❌ 7 regressed benchmarks
✅ 275 untouched benchmarks
⏩ 38 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Memory sort_unique_locale[500000] 33.6 MB 39.8 MB -15.5%
❌ Memory sort_ascii_only[500000] 22.2 MB 28.3 MB -21.77%
❌ Memory sort_long_line[160000] 712.6 KB 981.4 KB -27.39%
❌ Memory sort_mixed_data[500000] 22.9 MB 27.1 MB -15.71%
❌ Memory sort_numeric[500000] 75.5 MB 79.2 MB -4.67%
❌ Memory sort_accented_data[500000] 22.1 MB 28.3 MB -21.79%
❌ Memory sort_key_field[500000] 47.8 MB 51.8 MB -7.62%

Comparing sylvestre:tee-a (14c517e) with main (f2bec7b)

Open in CodSpeed

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@ChrisDryden ChrisDryden merged commit d943324 into uutils:main Jan 17, 2026
156 of 157 checks passed
@sylvestre sylvestre deleted the tee-a branch January 18, 2026 09:32
mattsu2020 pushed a commit to mattsu2020/coreutils that referenced this pull request Jan 23, 2026
@sylvestre @mattsu2020
tee: allow multiple -a flags (uutils#10293)
f5dae67 
Fixes issue where tee rejected multiple append flags with error
"the argument '--append' cannot be used multiple times".
GNU tee accepts multiple -a flags, so this adds compatibility.
@moonfruit moonfruit mentioned this pull request Feb 3, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisDryden ChrisDryden ChrisDryden approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sylvestre @ChrisDryden